Review Request 116886: Refactor private variables of KCompletion

Aleix Pol Gonzalez aleixpol at kde.org
Wed Mar 19 01:23:59 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116886/#review53379
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On March 18, 2014, 11:01 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116886/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> Refactor private variables of KCompletion
> 
> Also: reorder variables declaration to avoid padding
> 
> 
> Diffs
> -----
> 
>   src/kcompletion_p.h e3fad26 
>   src/kcompletion.cpp 7396029 
> 
> Diff: https://git.reviewboard.kde.org/r/116886/diff/
> 
> 
> Testing
> -------
> 
> It builds. Autotests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140319/9497110c/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list