Review Request 116887: Undeprecate setUrlDropsEnabled(bool) in KComboBox and KLineEdit
David Gil Oliva
davidgiloliva at gmail.com
Tue Mar 18 23:22:15 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116887/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kcompletion
Description
-------
Undeprecate setUrlDropsEnabled(bool) in KComboBox and KLineEdit
Apidox say it to be deprecated and use installEventFilter with a
LineEditUrlDropEventFilter instead. But that's precisely what
setUrlDropsEnabled does, so I don't see the point of making the user
do it when there's already a one-line method for that.
Diffs
-----
src/klineedit.h 76a1f01
src/kcombobox.h eea930d
src/kcombobox.cpp 30edc1b
Diff: https://git.reviewboard.kde.org/r/116887/diff/
Testing
-------
It builds. The compiler warnings about this deprecation disappear.
Thanks,
David Gil Oliva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140318/7caaa932/attachment.html>
More information about the Kde-frameworks-devel
mailing list