Review Request 116792: Fix deprecation warning in KComboBox and fix all KDE_NO_DEPRECATED
Commit Hook
null at kde.org
Tue Mar 18 22:28:14 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116792/#review53375
-----------------------------------------------------------
This review has been submitted with commit 6a37beb407d755d619ece5abafdef770db3b4b71 by David Gil to branch master.
- Commit Hook
On March 13, 2014, 10:58 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116792/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 10:58 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> Fix deprecation warning in KComboBox and fix all KDE_NO_DEPRECATED
>
> There are other warnings related to the deprecated KComboBox::setUrlDropsEnabled, which calls KLineEdit::setUrlDropsEnabled (also deprecated). I tried to solve it by copying the KLineEdit::setUrlDropsEnabled contents into KComboBox::setUrlDropsEnabled, but it contains private variables which it cannot see. Any hint??
>
>
> Diffs
> -----
>
> autotests/klineedit_unittest.cpp b84e126
> src/kcombobox.h 32dc3e9
> src/kcombobox.cpp 7195b3e
> src/kcompletion.h 387a05e
> src/klineedit.h c7c46b5
> src/klineedit.cpp ae15093
>
> Diff: https://git.reviewboard.kde.org/r/116792/diff/
>
>
> Testing
> -------
>
> It builds and tests pass.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140318/e9118563/attachment.html>
More information about the Kde-frameworks-devel
mailing list