Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX
Alexander Richardson
arichardson.kde at googlemail.com
Tue Mar 18 21:19:02 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116883/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kcoreaddons
Description
-------
Fix KUserGroup::users() and KUserGroup::userNames() on UNIX
The gr_mem member of struct group does not contain the names of users
where the primary group is equal to that group. In order to fix this we
have to iterate over all users and check whether the primary gid matches
the requested group. Unlike getgrouplist() there does not seem to be a
function that performs this task for us.
Diffs
-----
src/lib/util/kuser_unix.cpp 0e0720dbb614015d6d568b39da3cab77cece76a8
Diff: https://git.reviewboard.kde.org/r/116883/diff/
Testing
-------
Listed groups seem to be correct now. Should fix Jenkins together with https://git.reviewboard.kde.org/r/116881/
Thanks,
Alexander Richardson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140318/f4944a90/attachment.html>
More information about the Kde-frameworks-devel
mailing list