Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

Commit Hook null at kde.org
Tue Mar 18 12:17:19 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115918/#review53313
-----------------------------------------------------------


This review has been submitted with commit c1b5bb1298390a2e8a843f710212c193e0d25d50 by Alex Richardson to branch master.

- Commit Hook


On March 15, 2014, 3:37 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115918/
> -----------------------------------------------------------
> 
> (Updated March 15, 2014, 3:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Stephen Kelly.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Fix kservice_desktop_to_json for Visual Studio
> 
> The CMake generator for Visual Studio cannot handle the new build-time
> kservice_desktop_to_json macro -> fall back to configure-time generation
> 
> 
> Diffs
> -----
> 
>   KF5ServiceMacros.cmake 55fba4288dd16a97bf388f77c5c923c6136fab81 
> 
> Diff: https://git.reviewboard.kde.org/r/115918/diff/
> 
> 
> Testing
> -------
> 
> ktexteditor fails to build before this patch (because moc can't find the .json file), with the patch it compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140318/bcf9280c/attachment.html>


More information about the Kde-frameworks-devel mailing list