Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116845/
-----------------------------------------------------------

(Updated March 17, 2014, 11:17 p.m.)


Review request for KDE Frameworks and Matthew Dawson.


Changes
-------

Now 3 commits, readConfig not virtual anymore.


Summary (updated)
-----------------

Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.


Repository: kconfig


Description (updated)
-------

Make readConfig() non-virtual anymore, it's not useful.

Apps can reimplement usrReadConfig() or the readConfig() in every item instead.

Remove unnecessary debug output


Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

Call it from generated singletons, since the constructor creates
a KConfig from a filename, which already loads from disk.
This removes the need for using DelayedParsing.


Diffs (updated)
-----

  autotests/kconfig_compiler/test10.cpp.ref 21aea9d87af5fce01e64032257283e0883af2d81 
  autotests/kconfig_compiler/test1main.cpp d7dc038d91d2f8babcd281960100d1c6fa264d7c 
  autotests/kconfig_compiler/test4.cpp.ref 66d0357f114b0aca6148a2091880dd2f62fbf624 
  autotests/kconfig_compiler/test4main.cpp 8f1c1ec8d41ea123893a59526c52cdbd0b5ee075 
  autotests/kconfig_compiler/test5.cpp.ref 088cc78f4dc96a719628ece342e149553c1d22aa 
  autotests/kconfig_compiler/test8b.cpp.ref dcd61693ff86f02eaeb93b4c4da9e6ed20463469 
  autotests/kconfig_compiler/test_dpointer.cpp.ref e50bf8aa29a2d009c4156dabf429c3ffb74eb7ba 
  autotests/kconfig_compiler/test_signal.cpp.ref 35b5cba2736761753d1ba32baa6f9fc2e7808ba1 
  autotests/kconfigskeletontest.cpp 31278e767655f7e3d25a4ed9984345e8c4e67d82 
  src/core/kcoreconfigskeleton.h a2b828a4ef3f881b551049901d4bc26bb23a014b 
  src/core/kcoreconfigskeleton.cpp 0c1a96faaa9c511d349a26ad8af4b7b2c9bf313e 
  src/kconfig_compiler/kconfig_compiler.cpp 7d84cfbc28b1648ca999116726455183d88a7f0a 

Diff: https://git.reviewboard.kde.org/r/116845/diff/


Testing
-------

Added two unittests (which is how I discovered I had to remove DelayedParsing, so the tests were useful).

The "bool ok + qWarning" thing is a bit clumsy, maybe we want to port these main() to qtestlib too, even though they are themselves executed by a unittest :-)


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140317/b2d29f2c/attachment.html>