Review Request 116830: Replace use of QPA headers with optional dep on QX11Extras.

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116830/#review53165
-----------------------------------------------------------

Ship it!


It's up to you if you want to wait for Kevin's approval for the extra dependency, although my view is that QX11Extras is a perfectly reasonable optional dependency for any framework (and the same would be true of the windows equivalent).

- Alex Merry


On March 16, 2014, 9:32 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116830/
> -----------------------------------------------------------
> 
> (Updated March 16, 2014, 9:32 a.m.)
> 
> 
> Review request for KDE Frameworks, Kevin Ottens and Martin Gräßlin.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> -------
> 
> Replace use of QPA headers with optional dep on QX11Extras.
> 
> If QX11Extras is unavailable, fall-back to dummy implementation, just like
> when xcb libs are not available, or on Mac/Windows/...
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt a269b9eadf5ef1119320ced26157530cf55558de 
>   src/util/kmodifierkeyinfoprovider_x11.cpp f5d2d1a6e5af13e07ed4f184f4222c96347bd70b 
> 
> Diff: https://git.reviewboard.kde.org/r/116830/diff/
> 
> 
> Testing
> -------
> 
> Compiling kguiaddons with and without qtx11extras available, on Linux/X11. Works.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140317/76ac09ef/attachment-0001.html>