Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116787/
-----------------------------------------------------------

(Updated March 17, 2014, 9 a.m.)


Review request for KDE Frameworks, kwin and Martin Gräßlin.


Changes
-------

fixed nitpicks, added a(n auto) unit test, fixed when called from main thread and added some documentation.


Repository: kwindowsystem


Description
-------

When using KWindowInfo from a thread other than the main application thread, the application fails on an assert triggered by creating a QWidget in another thread. This is due to NETEventFilter being a QWidget. This patch addresses the issue by using a QObject to create the NETEventFilter, which is itself first moved to the main application thread. 


Diffs (updated)
-----

  autotests/CMakeLists.txt 073b6dd 
  autotests/kwindowsystem_threadtest.cpp PRE-CREATION 
  src/kwindowsystem.cpp 4c17baa 
  src/kwindowsystem_p_x11.h 75f3028 
  src/kwindowsystem_x11.cpp 95c396b 

Diff: https://git.reviewboard.kde.org/r/116787/diff/


Testing
-------

Used in the Sprinter Windows plugin and works lovely to find desktops, windows, etc.


Thanks,

Aaron J. Seigo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140317/777e97b5/attachment.html>