Review Request 116591: Use dedicated NET::Properties and NET::Properties2 in NETWinInfo

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116591/
-----------------------------------------------------------

(Updated March 17, 2014, 8:03 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kwindowsystem


Description
-------

Use dedicated NET::Properties and NET::Properties2 in NETWinInfo

This replaces the usage of the unsinged long[] array with
NET::Properties as first element and optional NET::Properties2 as
second element by a dedecated variable for each of them.

This includes the following changes:
* NETWinInfo::event(xcb_generic_event_t*) return NET::Properties
* new overload added for NETWinInfo::event taking NET::Properties*
  and NET::Properties2* as arguments
* existing overload for NETWinInfo::event taking unsigned long* as
  argument is deprecated and forwards to the new added overload
* NETWinInfo::passedProperties returns NET::Properties and a new
  NETWinInfo::passedProperties2 is added which returns the
  NET::Properties2. This is a SC-break, but it's only used internally
  in KWindowInfo
* ctor taking unsigned long* is changed to taking NET::Properties and
  NET::Properties2. This is also a SC-break, but the ctor broke already
  caused by the change from Display* to xcb_connection_t*
* other ctor is deprecated as the difference is no longer relevant


Diffs
-----

  autotests/netwininfotestclient.cpp 030881cf47ddc38b89e49a59dfd5deff309a0038 
  autotests/netwininfotestwm.cpp 5a6697c56462d52777cc9eec0a3eb5b3d03b7693 
  src/kwindowinfo_x11.cpp 358bcfedc6c5c75c104fbb4ec3666bd8578bff7d 
  src/netwm.h a5ad46fa1f0255ca6719224079bdea4598b48c51 
  src/netwm.cpp 288a34348f464e1158640afa1d931d9d05690cc4 
  src/netwm_p.h 1c26d47257a4f3ce71c360c394cc5be16f32b18c 

Diff: https://git.reviewboard.kde.org/r/116591/diff/


Testing
-------

unit tests still succeed; further testing: KWin and Plasma are still working


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140317/f99a510c/attachment.html>