Review Request 116090: Use $<TARGET_FILE:...> instead of get_target_property(... LOCATION)

Alexander Richardson arichardson.kde at googlemail.com
Sat Mar 15 15:31:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116090/
-----------------------------------------------------------

(Updated March 15, 2014, 4:31 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Repository: kde4support


Description
-------

Use $<TARGET_FILE:...> instead of get_target_property(... LOCATION)

This means CMake no longer warns about Policy CMP0026 is not set when
building projects that need kde4support


Diffs
-----

  cmake/modules/ECMQt4To5Porting.cmake 4204fa541790aa38c74b9d6f0b2111af2157b2bc 
  cmake/modules/KDE4Macros.cmake 192094b1c5c6877cd9dfa18dc27338c491d753f3 
  src/CMakeLists.txt 6bda0996c118ce212860e02d0505fd3bdc026833 
  src/KDEUIMacros.cmake 1570df340a672a597a0b7480885c340faca0069d 

Diff: https://git.reviewboard.kde.org/r/116090/diff/


Testing
-------

kde4support compiles, kde-workspace compiles


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140315/0d3fd69d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list