Review Request 116747: Clean up KCompletionBox
Alex Merry
alex.merry at kde.org
Sat Mar 15 01:08:36 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/#review52953
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Merry
On March 14, 2014, 8:46 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116747/
> -----------------------------------------------------------
>
> (Updated March 14, 2014, 8:46 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> Clean up KCompletionBox
>
> -canceled() -> cancelled (private method)
> -Deprecate sizeAndPosition() --> resizeAndReposition()
> -Remove old comments and commented-out code
> -Move some slots to be normal methods, since they don't seem to be able to
> work as slots.
>
>
> Diffs
> -----
>
> src/kcompletionbox.h 09b7527
> src/kcompletionbox.cpp 92e87b3
>
> Diff: https://git.reviewboard.kde.org/r/116747/diff/
>
>
> Testing
> -------
>
> It builds and tests pass.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140315/a97a1423/attachment.html>
More information about the Kde-frameworks-devel
mailing list