Review Request 116747: Clean up KCompletionBox
David Gil Oliva
davidgiloliva at gmail.com
Thu Mar 13 22:13:36 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/
-----------------------------------------------------------
(Updated March 13, 2014, 10:13 p.m.)
Review request for KDE Frameworks.
Changes
-------
Restore and rephrase comment in kcompletionbox.cpp, following suggestion of Alex Merry.
Repository: kcompletion
Description
-------
Clean up KCompletionBox
-canceled() -> cancelled (private method)
-Deprecate sizeAndPosition() --> resizeAndReposition()
-Remove old comments and commented-out code
-Move some slots to be normal methods, since they don't seem to be able to
work as slots.
Diffs (updated)
-----
src/kcompletionbox.h 09b7527
src/kcompletionbox.cpp 92e87b3
Diff: https://git.reviewboard.kde.org/r/116747/diff/
Testing
-------
It builds and tests pass.
Thanks,
David Gil Oliva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140313/cb9dc6dc/attachment.html>
More information about the Kde-frameworks-devel
mailing list