Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

[David Faure]

> On March 13, 2014, 7:54 p.m., Matthew Dawson wrote:
> > src/core/kcoreconfigskeleton.cpp, line 990
> > <https://git.reviewboard.kde.org/r/116689/diff/1/?file=253151#file253151line990>
> >
> >     Also, can you change the documentation for KCoreConfigSkeleton to reflect this change?  Specifically, for the configname parameter, can you change it something like:
> >     name of config file. If no name is given, the default from KSharedConfig::openConfig() is used
> 
> David Faure wrote:
>     I don't understand, the documentation already says that.
>     Do you mean mentionning DelayedParsing in the documentation?
>     It's kind of an internal detail though.
> 
> Matthew Dawson wrote:
>     It does basically say that.  The current text is:
>     name of config file. If no name is given, the default config file as returned by KSharedConfig::openConfig() is used
>     
>     I just worry the wording may have people assume we don't change any other parameters, though it could just be me looking to closely at this issue.  If you think the current version is more clear, then the patch can go in as is.  If you have a third option, I'm happy for to hear it, otherwise I'd prefer the updated version.

I cannot see a meaningful difference between "the default config file as returned by openConfig()" and "the default from openConfig()" ?
I kind of doubt anyone reading the docs would really see a difference there.
In fact the first one is arguably more correct, since we use the default config file but not with the default flags...


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116689/#review52902
-----------------------------------------------------------


On March 13, 2014, 8:06 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116689/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 8:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> KCoreConfigSkeleton: delay parsing until the call to readConfig()
> 
> 
> Diffs
> -----
> 
>   src/core/kconfig.h d27eebe7c41cb433b1808882c53cbf7b4c870950 
>   src/core/kconfig.cpp 5b51cce8c62c2c4de91baddcd3fb2893b842326d 
>   src/core/kcoreconfigskeleton.cpp 9c5fb4a80d500e81b483b749a137ad5f2c99a55f 
> 
> Diff: https://git.reviewboard.kde.org/r/116689/diff/
> 
> 
> Testing
> -------
> 
> strace -e open kate |& grep -v NOENT | grep oxygenrc
>  goes from 4 to 3
> (still three because the same KSharedConfig is used in 3 skeletons -> 3 * readConfig calling reparseConfiguration)
> 
> To go further down we could add a flag to readConfig()....
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140313/dd11384f/attachment.html>