Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116689/
-----------------------------------------------------------

(Updated March 13, 2014, 8:06 p.m.)


Review request for KDE Frameworks and Matthew Dawson.


Changes
-------

Ah! Fixed my post-review git alias using
--revision-range=HEAD~:HEAD


Repository: kconfig


Description
-------

KCoreConfigSkeleton: delay parsing until the call to readConfig()


Diffs (updated)
-----

  src/core/kconfig.h d27eebe7c41cb433b1808882c53cbf7b4c870950 
  src/core/kconfig.cpp 5b51cce8c62c2c4de91baddcd3fb2893b842326d 
  src/core/kcoreconfigskeleton.cpp 9c5fb4a80d500e81b483b749a137ad5f2c99a55f 

Diff: https://git.reviewboard.kde.org/r/116689/diff/


Testing
-------

strace -e open kate |& grep -v NOENT | grep oxygenrc
 goes from 4 to 3
(still three because the same KSharedConfig is used in 3 skeletons -> 3 * readConfig calling reparseConfiguration)

To go further down we could add a flag to readConfig()....


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140313/7aa2540a/attachment.html>