Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

[David Faure]

> On March 13, 2014, 7:54 p.m., Matthew Dawson wrote:
> > src/core/kconfigini.cpp, lines 86-89
> > <https://git.reviewboard.kde.org/r/116689/diff/1/?file=253150#file253150line86>
> >
> >     Is there a reason for these extra debug statements?

Argh, that stupid post-review script+alias always grabs local uncommitted changes while I only want to push the last commit. Let me try to fix that....


> On March 13, 2014, 7:54 p.m., Matthew Dawson wrote:
> > src/core/kcoreconfigskeleton.cpp, line 990
> > <https://git.reviewboard.kde.org/r/116689/diff/1/?file=253151#file253151line990>
> >
> >     Also, can you change the documentation for KCoreConfigSkeleton to reflect this change?  Specifically, for the configname parameter, can you change it something like:
> >     name of config file. If no name is given, the default from KSharedConfig::openConfig() is used

I don't understand, the documentation already says that.
Do you mean mentionning DelayedParsing in the documentation?
It's kind of an internal detail though.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116689/#review52902
-----------------------------------------------------------


On March 10, 2014, 8:36 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116689/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 8:36 a.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> KCoreConfigSkeleton: delay parsing until the call to readConfig()
> 
> 
> Diffs
> -----
> 
>   src/core/kconfig.h d27eebe7c41cb433b1808882c53cbf7b4c870950 
>   src/core/kconfig.cpp 5b51cce8c62c2c4de91baddcd3fb2893b842326d 
>   src/core/kconfigini.cpp df834f57fc44bbf9f4f28f1bc4eb5717e2ff1cee 
>   src/core/kcoreconfigskeleton.cpp 9c5fb4a80d500e81b483b749a137ad5f2c99a55f 
> 
> Diff: https://git.reviewboard.kde.org/r/116689/diff/
> 
> 
> Testing
> -------
> 
> strace -e open kate |& grep -v NOENT | grep oxygenrc
>  goes from 4 to 3
> (still three because the same KSharedConfig is used in 3 skeletons -> 3 * readConfig calling reparseConfiguration)
> 
> To go further down we could add a flag to readConfig()....
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140313/08af878d/attachment.html>