Review Request 116781: List catalog from all install dirs

Luigi Toscano luigi.toscano at tiscali.it
Thu Mar 13 12:36:42 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116781/#review52886
-----------------------------------------------------------

Ship it!


Thank you; I can't test now but it looks sane; as a suggestion, I would explicitly mention that this is for "environments where each module is installed using a different prefix" as I wrote in the related commit (for https://git.reviewboard.kde.org/r/116670/).

- Luigi Toscano


On March 13, 2014, 12:59 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116781/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 12:59 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> This makes sure that if XDG_DATA_DIRS contains kde4support install prefix and then kdoctools install prefix, then kdoctools catalogs are listed nevertheless.
> 
> Should fix build of kde-workspace and kate on build.kde.org.
> 
> 
> Diffs
> -----
> 
>   src/xslt.cpp 6d5819e 
> 
> Diff: https://git.reviewboard.kde.org/r/116781/diff/
> 
> 
> Testing
> -------
> 
> Rebuilt kde-runtime (was failing there), kate and kde-workspace. No build failures.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140313/1e38f44b/attachment.html>


More information about the Kde-frameworks-devel mailing list