Review Request 116766: Use a desktop file we might find for testing KServiceActions

David Faure faure at kde.org
Thu Mar 13 08:41:00 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116766/#review52874
-----------------------------------------------------------


It would have been better to just put a local copy of that desktop file into the kservice autotests subdir, so that it's always available to run the test on.
Now we depend on konsolerun.desktop which might change in the future, etc.
And this way we can add stuff to the desktop file to test more "Actions" features in the future.

- David Faure


On March 12, 2014, 3:47 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116766/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 3:47 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Use a desktop file we might find for testing KServiceActions
> 
> The screensaver stuff isn't ported to frameworks 5 yet, so looking for
> those desktop files won't work.  This uses something that might actually
> be installed instead.
> 
> 
> Diffs
> -----
> 
>   autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 
>   autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 
> 
> Diff: https://git.reviewboard.kde.org/r/116766/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140313/6efd23d2/attachment.html>


More information about the Kde-frameworks-devel mailing list