Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

[Martin Gräßlin]

> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote:
> > I don't think papering over the X11-ness of kdesu like this is the right approach.  Of course, what this framework really needs is a test app; maybe a simple port of the kdesu app from kde-runtime?
> 
> Kevin Ottens wrote:
>     This kind of "papering over" can only be temporary indeed. Just wondering if Martin has the possibility to clean that up better at that stage?
>     
>     As for the test app: hell yes, definitely needed.
> 
> Martin Gräßlin wrote:
>     well yes if there's a testapp and that works I can implement it properly. But IIRC kdesu never worked on my setup (not having a password for root).
> 
> Kevin Ottens wrote:
>     You can use it for other users than root you know. ;-)
> 
> Martin Gräßlin wrote:
>     no, I didn't and which other users? ;-)
> 
> Kevin Ottens wrote:
>     My point is that if you need to test it's trivial to add a temporary user...
> 
> Kevin Ottens wrote:
>     So what do we do of this patch? Any chance of a test app?

> Any chance of a test app?

I would prefer if the test app could be integrated by a domain expert. I do not really feel comfortable about it.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review50240
-----------------------------------------------------------


On Feb. 13, 2014, 10:41 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 10:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> -------
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -----
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140313/68d30355/attachment-0001.html>