Review Request 116747: Clean up KCompletionBox

[David Gil Oliva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/
-----------------------------------------------------------

(Updated March 12, 2014, 10:54 p.m.)


Review request for KDE Frameworks.


Changes
-------

Address Alex and Aleix suggestions.


Repository: kcompletion


Description
-------

Clean up KCompletionBox

-canceled() -> cancelled (private method)
-Deprecate sizeAndPosition() --> resizeAndReposition()
-Remove old comments and commented-out code
-Move some slots to be normal methods, since they don't seem to be able to
work as slots.


Diffs (updated)
-----

  src/kcompletionbox.h 09b7527 
  src/kcompletionbox.cpp 92e87b3 

Diff: https://git.reviewboard.kde.org/r/116747/diff/


Testing
-------

It builds and tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140312/add5d9c1/attachment.html>