Review Request 116747: Clean up KCompletionBox
David Gil Oliva
davidgiloliva at gmail.com
Wed Mar 12 09:14:54 UTC 2014
> On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote:
> > src/kcompletionbox.h, line 228
> > <https://git.reviewboard.kde.org/r/116747/diff/1/?file=253404#file253404line228>
> >
> > I wouldn't leave the implementation here. Move it to the .cpp file, this way it can be changed in the future, if it's required for some reason.
> >
> > Also there's a typo in the method name.
Alex Merry inlined deprecated methods in https://git.reviewboard.kde.org/r/116012 , so I thought that it was the way to go...
On March 11, 2014, 11:17 p.m., David Gil Oliva wrote:
> > Have you looked through the uses of the "un-slotted" methods? (lxr.kde.org). Maybe there's a reason for that... :/
Maybe I'm totally wrong, but I can't imagine any way that a getter can be useful as a slot.
connect (widget, SLOT(valueChanged(), completionBox, SIGNAL(isTabHandling());
Does it make sense? ¿?:-/
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/#review52703
-----------------------------------------------------------
On March 11, 2014, 10:32 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116747/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 10:32 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> Clean up KCompletionBox
>
> -canceled() -> cancelled (private method)
> -Deprecate sizeAndPosition() --> resizeAndReposition()
> -Remove old comments and commented-out code
> -Move some slots to be normal methods, since they don't seem to be able to
> work as slots.
>
>
> Diffs
> -----
>
> src/kcompletionbox.h 09b7527
> src/kcompletionbox.cpp 92e87b3
>
> Diff: https://git.reviewboard.kde.org/r/116747/diff/
>
>
> Testing
> -------
>
> It builds and tests pass.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140312/53899d71/attachment.html>
More information about the Kde-frameworks-devel
mailing list