Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116650/#review52690
-----------------------------------------------------------

Ship it!


Perfect, thanks!

- Luigi Toscano


On March 11, 2014, 12:05 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116650/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 12:05 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> While porting the documentation in kde-runtime I realized there was an error because when running cmake it would try to create different targets and some of them would have the same name (e.g. there is kcm/bookmarks and kio/bookmarks, and it uses the directory name to figure out the filename).
> 
> I would have fixed that, but then I realised it was not running any command and nothing depended on it. Am I missing something?
> 
> 
> Diffs
> -----
> 
>   KF5DocToolsMacros.cmake 6567b67 
> 
> Diff: https://git.reviewboard.kde.org/r/116650/diff/
> 
> 
> Testing
> -------
> 
> Now kde-runtime documentation builds.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140311/934ae23c/attachment.html>