Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8
Aurélien Gâteau
agateau at kde.org
Tue Mar 11 08:29:26 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116696/#review52619
-----------------------------------------------------------
Ship it!
I can reproduce the failure on ktexteditor with cmake 2.8.12.2. The patch fixes it, thanks!
- Aurélien Gâteau
On March 10, 2014, 3 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116696/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 3 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> execute_process won't translate the generation expression into a path, so it refuses to work.
>
> In this case using get_property(... LOCATION) it's fine because it's only used as an imported target.
>
>
> Diffs
> -----
>
> KF5ServiceMacros.cmake fd835bd
>
> Diff: https://git.reviewboard.kde.org/r/116696/diff/
>
>
> Testing
> -------
>
> Now I can build frameworks that use kservice_desktop_to_json.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140311/455856a8/attachment.html>
More information about the Kde-frameworks-devel
mailing list