Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

[Sebastian Kügler]

> On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote:
> > Strange, it works fine here. Which version of CMake are you using and which repository is failing?
> 
> Aurélien Gâteau wrote:
>     Oh, version is in the request title. /me tests with 2.8.
> 
> Aurélien Gâteau wrote:
>     Just tried with 2.8.12, which is the lowest supported version IIRC (at least KF5ConfigTargets.cmake thinks so) and it works for me.
> 
> Alex Merry wrote:
>     Assuming this is linked to the previous RR on this topic, I think this is only with Visual Studio.
> 
> Aleix Pol Gonzalez wrote:
>     Nope, this is on linux: cmake version 2.8.12.2
>
> 
> Aurélien Gâteau wrote:
>     You still haven't answered the second part: which repository?
> 
> Sebastian Kügler wrote:
>     In my case, cmake-git (built with kdesrc-build).
> 
> Aurélien Gâteau wrote:
>     I meant: which framework fails to build?
> 
> Aleix Pol Gonzalez wrote:
>     I think KDBusTools and KTextEditor were failing for me.

I had ktexteditor failing as well, and a whole bunch of stuff in plasma-framework, kde-runtime and kde-workspace.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116696/#review52551
-----------------------------------------------------------


On March 10, 2014, 2 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116696/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 2 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> execute_process won't translate the generation expression into a path, so it refuses to work.
> 
> In this case using get_property(... LOCATION) it's fine because it's only used as an imported target.
> 
> 
> Diffs
> -----
> 
>   KF5ServiceMacros.cmake fd835bd 
> 
> Diff: https://git.reviewboard.kde.org/r/116696/diff/
> 
> 
> Testing
> -------
> 
> Now I can build frameworks that use kservice_desktop_to_json.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140310/36e0871b/attachment-0001.html>