Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

Aleix Pol Gonzalez aleixpol at kde.org
Mon Mar 10 14:00:39 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116696/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kservice


Description
-------

execute_process won't translate the generation expression into a path, so it refuses to work.

In this case using get_property(... LOCATION) it's fine because it's only used as an imported target.


Diffs
-----

  KF5ServiceMacros.cmake fd835bd 

Diff: https://git.reviewboard.kde.org/r/116696/diff/


Testing
-------

Now I can build frameworks that use kservice_desktop_to_json.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140310/cb2199ca/attachment.html>


More information about the Kde-frameworks-devel mailing list