Review Request 116685: Import documentationnotfound in kio, used by kio-help
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Mar 10 04:32:47 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116685/#review52481
-----------------------------------------------------------
Ship it!
I would say it makes sense.
I wonder why it's not here... http://community.kde.org/Frameworks/Epics/New_Runtime_Organization
- Aleix Pol Gonzalez
On March 10, 2014, 12:01 a.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116685/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 12:01 a.m.)
>
>
> Review request for Documentation and KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> The special document documentationnotfound is provided by kde-runtime/khelpcenter and if found it is used by kio-help when the requested documentation is not available. I think it makes more sense to have it where kio-help lives.
>
>
> Please note the import would include the (short) history of the documentationnotfound directory (and its index.docbook and CMakeLists.txt) extracted from kde-runtime history.
>
>
> Diffs
> -----
>
> docs/kioslave/help/CMakeLists.txt 73e1506
> docs/kioslave/help/documentationnotfound/CMakeLists.txt PRE-CREATION
> docs/kioslave/help/documentationnotfound/index.docbook PRE-CREATION
> src/ioslaves/help/kio_help.cpp d693442
>
> Diff: https://git.reviewboard.kde.org/r/116685/diff/
>
>
> Testing
> -------
>
> kioclient cat help:/foobar shows the content of documentationnotfound instead of "There is no documentation available for /foobar."
>
>
> Thanks,
>
> Luigi Toscano
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140310/e0e66680/attachment.html>
More information about the Kde-frameworks-devel
mailing list