Review Request 116681: Fix kio-help by adding a separator

Luigi Toscano luigi.toscano at tiscali.it
Sun Mar 9 21:49:35 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116681/
-----------------------------------------------------------

(Updated March 9, 2014, 9:49 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kio


Description
-------

Looking at the code it seems that QStandardPaths::locateAll() does not add the final '/' as the previous kdelibs code.

Without this fix kio-help does find the documentation.

General remark: maybe other parts of code which use QStandardPaths should be checked.


Diffs
-----

  src/ioslaves/help/kio_help.cpp 85b7975 

Diff: https://git.reviewboard.kde.org/r/116681/diff/


Testing
-------

kioclient cat help:/kioslave/ftp (from frameworks branch of kde-runtime) now works.


Thanks,

Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140309/e55a4838/attachment.html>


More information about the Kde-frameworks-devel mailing list