Review Request 116639: Do not read LOCATION property of desktoptojson
Alex Merry
alex.merry at kde.org
Thu Mar 6 22:52:04 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116639/#review52312
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Merry
On March 6, 2014, 3:42 p.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116639/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 3:42 p.m.)
>
>
> Review request for Build System and KDE Frameworks.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> This makes the code CMP0026 compliant. Surprisingly I never saw the CMake warning about this policy. Don't know why.
>
>
> Diffs
> -----
>
> KF5ServiceMacros.cmake f70a185
>
> Diff: https://git.reviewboard.kde.org/r/116639/diff/
>
>
> Testing
> -------
>
> Tested with kservice/tests/kservicetojsontest, using both the old and the new syntax. Rebuilt kde-workspace.
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140306/3b0fe58b/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list