Review Request 116615: Remove deprecated method languageForEncoding()

David Faure faure at kde.org
Wed Mar 5 14:34:52 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116615/#review52086
-----------------------------------------------------------

Ship it!


"This function will be removed before KDE4 is released."  < priceless.



http://lxr.kde.org/ident?i=languageForEncoding says : go ahead.

- David Faure


On March 5, 2014, 2:29 p.m., John Layt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116615/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 2:29 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Repository: kcodecs
> 
> 
> Description
> -------
> 
> Remove method KCharSets::languageForEncoding() which is marked as deprecated and to be removed for KDE4.
> 
> 
> Diffs
> -----
> 
>   src/kcharsets.h 0baedd28a72248a2ef974ff2ea539409a23fe0fd 
>   src/kcharsets.cpp b140074a82384111074ee9876048718c76b98523 
> 
> Diff: https://git.reviewboard.kde.org/r/116615/diff/
> 
> 
> Testing
> -------
> 
> Autotests pass.
> 
> 
> Thanks,
> 
> John Layt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140305/0e2d27dd/attachment.html>


More information about the Kde-frameworks-devel mailing list