Review Request 116090: Use $<TARGET_FILE:...> instead of get_target_property(... LOCATION)

[Alex Merry]

> On Feb. 27, 2014, 9:54 a.m., Alex Merry wrote:
> > The problem with doing this in support code is that it is not strictly source compatible.  An example this would break is if you want to embed the value of QT_QMAKE_EXECUTABLE into a C++ executable using something like
> > add_definitions("-DQMAKE=\"${QT_QMAKE_EXECUTABLE}\"")
> > Any use of QMAKE in the program would then expand to "$<TARGET_FILE:Qt5::qmake>", which is obviously not what was wanted.
> 
> Alexander Richardson wrote:
>     Ah, didn't know that, should I drop this request?

Yeah, I don't think it's worth risking breakage for kde4support.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116090/#review51010
-----------------------------------------------------------


On Feb. 26, 2014, 5:03 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116090/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> Use $<TARGET_FILE:...> instead of get_target_property(... LOCATION)
> 
> This means CMake no longer warns about Policy CMP0026 is not set when
> building projects that need kde4support
> 
> 
> Diffs
> -----
> 
>   cmake/modules/ECMQt4To5Porting.cmake 4204fa541790aa38c74b9d6f0b2111af2157b2bc 
>   cmake/modules/KDE4Macros.cmake 192094b1c5c6877cd9dfa18dc27338c491d753f3 
>   src/CMakeLists.txt 6bda0996c118ce212860e02d0505fd3bdc026833 
>   src/KDEUIMacros.cmake 1570df340a672a597a0b7480885c340faca0069d 
> 
> Diff: https://git.reviewboard.kde.org/r/116090/diff/
> 
> 
> Testing
> -------
> 
> kde4support compiles, kde-workspace compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140305/8867b6ea/attachment.html>