Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon
Commit Hook
null at kde.org
Wed Mar 5 11:49:40 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review52056
-----------------------------------------------------------
This review has been submitted with commit a6c75f16514a2f8bb537f557bf8a07e957199171 by Martin Gräßlin to branch master.
- Commit Hook
On March 5, 2014, 11:14 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> -----------------------------------------------------------
>
> (Updated March 5, 2014, 11:14 a.m.)
>
>
> Review request for KDE Frameworks, Plasma and Marco Martin.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> Add menu support to KDEPlatformSystemTrayIcon
>
> Uses new QPA API which got introduced in Qt 5.3.
>
> Provide an implementation for QPlatformSystemTrayIcon
>
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
>
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
>
> This is adressed in Qt 5.3 which extends the QPA API.
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be
> src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c
> src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION
> src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION
> src/platformtheme/kdeplatformtheme.h f436eea4e3aa9cfda62654e5c6dc77aea05e8f27
> src/platformtheme/kdeplatformtheme.cpp a5d86c27385447b7744cb8bca0cf65889872fb0b
>
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
>
>
> Testing
> -------
>
> Using systray from qtbase/examples/widgets/desktop/systray
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140305/ca33bca5/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list