Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116603/
-----------------------------------------------------------

(Updated March 5, 2014, 11:49 a.m.)


Review request for KDE Frameworks.


Changes
-------

Add documentation, makes the method protected, just in case.


Repository: kwidgetsaddons


Description
-------

KPasswordDialog used to be a KDialog. There, users could interact with the buttons setup (like sudlg.cpp in kde-runtime/kdesu). The fact that it was re-based to QDialog, we lost the ability of editing the buttons at all.

This change exposes the buttonBox(), so the user re-gains this feature, through QDialogButtonBox.


Diffs (updated)
-----

  src/kpassworddialog.h 069e301 
  src/kpassworddialog.cpp cacf31a 

Diff: https://git.reviewboard.kde.org/r/116603/diff/


Testing
-------

Ported sudlg.cpp to it, they need it because it requires an "Ignore" button over there.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140305/39eeee90/attachment.html>