Review Request 116598: Check versions for individual components of Wayland

Aurélien Gâteau agateau at kde.org
Wed Mar 5 09:00:18 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/
-----------------------------------------------------------

(Updated March 5, 2014, 9 a.m.)


Status
------

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin.


Repository: extra-cmake-modules


Description
-------

First part of the diff makes sure find_package_handle_standard_args() gets a version number to check against.

Second part ensures we get proper results from pkg-config even if not all components are available. find_package(Wayland COMPONENTS Client Egl) was failing for me because I have Client installed but not Egl, causing pkg_check_modules() to not set any PKG_Wayland_${comp} variable.


Diffs
-----

  find-modules/FindWayland.cmake 21014fc 

Diff: https://git.reviewboard.kde.org/r/116598/diff/


Testing
-------

Together with a change for kde-workspace, it fixes the build of kde-workspace on my system with wayland-client 1.1 and no wayland-egl.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140305/3086904f/attachment.html>


More information about the Kde-frameworks-devel mailing list