Review Request 115875: kconfigtest: write everything into a subdirectory

[David Faure]

> On March 4, 2014, 9:11 p.m., David Faure wrote:
> > autotests/kconfigtest.cpp, line 86
> > <https://git.reviewboard.kde.org/r/115875/diff/2/?file=251983#file251983line86>
> >
> >     Just curious, what's the reason for the ".." then? Doesn't this still make this test potentially conflict with other tests that use kdeglobals?
> 
> Alexander Richardson wrote:
>     Yeah it does. But now only tests using kdeglobals are a problem, before it deleted the whole ~/.qttest/config directory which means all config files were lost.
> 
> David Faure wrote:
>     So why not just remove that "../" ?
> 
> Alexander Richardson wrote:
>     I thought the kdeglobals magic only works if it is in the root directory of the config path. If that is not the case I'll remove the ..

Oh I didn't realize that the config path was still unchanged, I see.

Right, QStandardPaths' test mode isn't configurable indeed.

OK then.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115875/#review51961
-----------------------------------------------------------


On March 4, 2014, 8:58 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115875/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 8:58 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> kconfigtest: write everything into a subdirectory
> 
> This test keeps deleting the whole ~/.qttest directory. By moving all data
> into a subdirectory it is now possible to run multiple tests that use
> kconfig in parallel.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfigtest.cpp 1c0dc1cf63539e29236ab57e1e848930b468053a 
> 
> Diff: https://git.reviewboard.kde.org/r/115875/diff/
> 
> 
> Testing
> -------
> 
> Test still passes. No files (except kdeglobals) are created in ~/.qttest/config
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140305/266222f2/attachment.html>