Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

[Lamarque Souza]

> On March 4, 2014, 4:42 p.m., Lamarque Souza wrote:
> > Ship It!
> 
> Lamarque Souza wrote:
>     This should be ported to branches master and NM/0.9.8 as well.
> 
> Alexander Richardson wrote:
>     How should I commit it? Commit to oldest branch and then merge? Or rather put this into qt5 and then apply patches to the other branches? The latter might make merging a bit harder.

I usually apply to master e cherry-pick individual commits to NM/0.9.8. The CMakeListst.txt in qt5 branch is quit different from the ones in the other branches, your patch does not apply.


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116098/#review51909
-----------------------------------------------------------


On March 4, 2014, 4:13 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116098/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 4:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and Sebastian Kügler.
> 
> 
> Repository: libnm-qt
> 
> 
> Description
> -------
> 
> Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs
> 
> This means there is no longer a need for passing -DLIB_SUFFIX=64 on e.g.
> openSuSE, since CMake will detect the correct install directory for most
> distributions. If for some reason CMake doesn't detect the correct
> directory it can be overriden using e.g. -DCMAKE_INSTALL_LIBDIR=lib32
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9918278 
>   NetworkManagerQt.pc.cmake 2c3ab07 
>   include/CMakeLists.txt 2b51ced 
>   include/settings/CMakeLists.txt 1a00bdb 
> 
> Diff: https://git.reviewboard.kde.org/r/116098/diff/
> 
> 
> Testing
> -------
> 
> Installed into the right directories after applying the patch.
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140305/0abbe459/attachment.html>