Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116603/#review51992
-----------------------------------------------------------

Ship it!


Should this remain internal API? If yes, please mark it as such. If not, please add some documentation.

- Christoph Feck


On March 4, 2014, 11:05 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116603/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 11:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> KPasswordDialog used to be a KDialog. There, users could interact with the buttons setup (like sudlg.cpp in kde-runtime/kdesu). The fact that it was re-based to QDialog, we lost the ability of editing the buttons at all.
> 
> This change exposes the buttonBox(), so the user re-gains this feature, through QDialogButtonBox.
> 
> 
> Diffs
> -----
> 
>   src/kpassworddialog.h 069e301 
>   src/kpassworddialog.cpp cacf31a 
> 
> Diff: https://git.reviewboard.kde.org/r/116603/diff/
> 
> 
> Testing
> -------
> 
> Ported sudlg.cpp to it, they need it because it requires an "Ignore" button over there.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/01e5bfe8/attachment.html>