Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

Aleix Pol Gonzalez aleixpol at kde.org
Tue Mar 4 23:11:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
-----------------------------------------------------------

(Updated March 4, 2014, 11:11 p.m.)


Review request for KDE Frameworks.


Changes
-------

Address David's remarks.

I'm a noob. >.<


Repository: kcoreaddons


Description
-------

Let the KAboutData set information to QApplication. This way we don't have to duplicate information by passing it to the KAboutData _and_ the QApplication.


Diffs (updated)
-----

  src/lib/kaboutdata.h 2222c9e 
  src/lib/kaboutdata.cpp c347521 

Diff: https://git.reviewboard.kde.org/r/115207/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/91c8b882/attachment.html>


More information about the Kde-frameworks-devel mailing list