Review Request 116561: Drop KWindowEffects::showWindowThumbnails

Kevin Ottens ervin at kde.org
Tue Mar 4 21:01:46 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116561/#review51957
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On March 3, 2014, 8:48 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116561/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 8:48 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Drop KWindowEffects::showWindowThumbnails
> 
> The effect got removed from KWin, thus it doesn't make any sense to
> expose the functionality in KWindowEffects.
> 
> As KWindowEffects is new in 5.0 it's removed and not deprecated. It
> used to be in Plasma::WindowEffects before.
> 
> 
> Diffs
> -----
> 
>   src/kwindoweffects_dummy.cpp c4e67e816157695bb49812e04f271ef1a0ea817c 
>   src/kwindoweffects.cpp 471e15d06fc2cd81a3a3f7c555d9140cab4536a1 
>   src/kwindoweffects.h e0c2b25026227065b885f3794dbcf4b8924441a7 
>   autotests/kwindoweffectstest.cpp 7a00ebc8e0e34f7244bf1e673645384e8c961459 
>   src/kwindoweffects_p.h fd26b03b9a627acdb6c9598c6df26b4f1d044930 
>   src/kwindoweffects_x11.cpp 8b1e1d186231be8118190cb04651ba3507f47da2 
> 
> Diff: https://git.reviewboard.kde.org/r/116561/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/f1d2d761/attachment.html>


More information about the Kde-frameworks-devel mailing list