Review Request 116545: Fix KHTML compilation when using clang.

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116545/#review51953
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On March 2, 2014, 9:11 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116545/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 9:11 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kjs
> 
> 
> Description
> -------
> 
> Fix KHTML compilation when using clang.
> 
> In file included from src/ecma/kjs_traversal.cpp:21:
> src/kjs_traversal.lut.h:49:18: error: constant expression
> evaluates to 4294967295 which cannot be narrowed to type 'int'
> [-Wc++11-narrowing]
>    { "SHOW_ALL", DOM::NodeFilter::SHOW_ALL,
>       KJS::DontDelete|KJS::ReadOnly, 0, 0 } ,
> 
> src/kjs_traversal.lut.h:49:18: note: override this message by
> inserting an explicit cast
>    { "SHOW_ALL", DOM::NodeFilter::SHOW_ALL,
>                  ^~~~~~~~~~~~~~~~~~~~~~~~~
>                  static_cast<int>(        )
> 
> 
> Diffs
> -----
> 
>   src/kjs/create_hash_table 94f3e4358a6d78fc7c658369d65b0e75ca131bc8 
> 
> Diff: https://git.reviewboard.kde.org/r/116545/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/f8d497bd/attachment-0001.html>