Review Request 116544: Fix clang compilation warning:

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116544/#review51952
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On March 2, 2014, 8:53 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116544/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 8:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> Fix clang compilation warning:
> 
> khtml/src/xml/dom_stringimpl.h:60:13: warning: cast from 'char *'
> to 'QChar *' increases required alignment from 1 to 2 [-Wcast-align
>         s = (QChar*) new cha sizeof(QChar)*( havestr ? len : 1 ) ;
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Note that this line of code is pretty odd I have to say. It this
> supposed to be an optimization to prevent the default ctor/dtor of
> QChar to be called? Is it really worth it here?
> 
> 
> Diffs
> -----
> 
>   src/xml/dom_stringimpl.h 114101d525309e423f50c5164d83afee8c634413 
> 
> Diff: https://git.reviewboard.kde.org/r/116544/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/97009e7b/attachment.html>