Review Request 116541: Fix compiler error when using clang:

Kevin Ottens ervin at kde.org
Tue Mar 4 20:53:40 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116541/#review51951
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On March 2, 2014, 8:12 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116541/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 8:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> Fix compiler error when using clang:
> 
> src/misc/AtomicString.cpp:175:28: error: non-constant-expression
>  cannot be narrowed from type 'int' to 'unsigned int' in initializer
>  list [-Wc++11-narrowing]
>     UCharBuffer buf = { s, length };
>                            ^~~~~~
> src/misc/AtomicString.cpp:175:28: note: override this message by
>  inserting an explicit cast
>     UCharBuffer buf = { s, length };
>                            ^~~~~~
>                            static_cast<unsigned int>( )
> 
> 
> Diffs
> -----
> 
>   src/misc/AtomicString.cpp 4c35662ddd47759ed7e70524ededdd5223c14c09 
> 
> Diff: https://git.reviewboard.kde.org/r/116541/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/b043ff12/attachment.html>


More information about the Kde-frameworks-devel mailing list