Review Request 116088: Remove FindDBusMenuQt5.cmake

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116088/#review51945
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Feb. 27, 2014, 12:19 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116088/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 12:19 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Remove FindDBusMenuQt5.cmake
> 
> dbusmenu-qt ships a CMake config file so we don't need a Find* file anymore.
> Unfortunately the target defined does not set the include dir so for the
> time being it is still necessary to call include_directories()
> (might look into this if I find time)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ef84eb6 
>   cmake/FindDBusMenuQt5.cmake 7d43489 
>   src/CMakeLists.txt 900cb38 
> 
> Diff: https://git.reviewboard.kde.org/r/116088/diff/
> 
> 
> Testing
> -------
> 
> Builds, manual tests run as expected.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/a7fe4f56/attachment.html>