Review Request 116568: Fixes to PIC image format handler

[Alex Merry]

> On March 4, 2014, 8:28 a.m., David Faure wrote:
> > src/imageformats/pic.cpp, line 452
> > <https://git.reviewboard.kde.org/r/116568/diff/2/?file=251701#file251701line452>
> >
> >     Does this work on both big endian and little endian architectures? It looks like it's extracting individual bytes out of an int, which is not portable...

Hm, I think you're right.  It also never checks or changes the QImage format.

Given that I'm the maintainer of the kimageformats, it may be worth me setting up an emulator for a big-endian architecture.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116568/#review51854
-----------------------------------------------------------


On March 3, 2014, 1:15 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116568/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 1:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> Fixes to PIC image format handler
> 
> Better error handling (returns false on error in read() and write()) and
> use the correct format if there is no alpha channel.
> 
> 
> Diffs
> -----
> 
>   src/imageformats/CMakeLists.txt 44f07dd7bfb7daa1be21ececdfb5061a262e0fc8 
>   src/imageformats/pic.cpp 9d8a7ede31c5c03a699d6a76c88aeb5e3d37ac4a 
>   src/imageformats/pic_read.cpp 484c63426723e04e5c7e96ae5355ccceccab03f4 
>   src/imageformats/pic_rw.h 2cc958927403de57049bbd7cb3200f0b7489da3c 
>   src/imageformats/pic_write.cpp 0632eebd507e58e480856b53e71c24afc543de26 
> 
> Diff: https://git.reviewboard.kde.org/r/116568/diff/
> 
> 
> Testing
> -------
> 
> Builds and tests pass, both with and without https://git.reviewboard.kde.org/r/116567/ applied.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/eb1c5254/attachment.html>