Review Request 116573: Make KI18n a private dependency in KIO

Aleix Pol Gonzalez aleixpol at kde.org
Tue Mar 4 00:18:19 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116573/
-----------------------------------------------------------

(Updated March 4, 2014, 12:18 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kio


Description
-------

Don't include klocalizedstring.h from slavebase.h.

It's odd and it was not specified by CMakeLists.txt (the alternative is to move KI18n to LINK_PUBLIC).


Diffs
-----

  src/ioslaves/help/kio_help.cpp 38e09d5 
  src/ioslaves/http/http.cpp a0193a0 
  src/ioslaves/ftp/ftp.cpp 706c983 
  src/core/slavebase.h 86f1506 
  src/core/slavebase.cpp 1236ad5 
  src/ioslaves/file/file.cpp b8c6220 
  src/ioslaves/file/file_unix.cpp 96fd6af 

Diff: https://git.reviewboard.kde.org/r/116573/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/837c9ae2/attachment.html>


More information about the Kde-frameworks-devel mailing list