Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Mar 4 00:06:34 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116103/#review51844
-----------------------------------------------------------
Ok, I just realized this was being dealt with and I did a different patch: https://git.reviewboard.kde.org/r/116573/
I think that having UI strings on a header file is quite bad TBH, but since I see there's consensus I'll discard it.
- Aleix Pol Gonzalez
On March 3, 2014, 8:59 p.m., Matthieu Gallien wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116103/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 8:59 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> include/KF5/KIOCore/kio/slavebase.h is including headers from KI18N and is publically installed.
>
>
> Diffs
> -----
>
> KF5KIOConfig.cmake.in 3a947b7
> src/core/CMakeLists.txt d897e37
>
> Diff: https://git.reviewboard.kde.org/r/116103/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matthieu Gallien
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/007ef79a/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list