Review Request 116567: Implement fuzzy image matching in readtest

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116567/
-----------------------------------------------------------

(Updated March 3, 2014, 3:23 p.m.)


Review request for KDE Frameworks.


Changes
-------

Only do fuzzing for XCF images.


Repository: kimageformats


Description (updated)
-------

Implement fuzzy image matching in readtest

Images are converted to ARGB32 format, then each byte (ie: each pixel
channel) in the read image is allowed to deviate by some specified
amount from the corresponding byte in the expected image, to allow for
rounding errors etc.

By default, no deviation is permitted, but the XCF tests are allowed a
deviation of 1, as the alpha blending can result in rounding errors
(depending on whether hardware acceleration is used, for example).  In
the end, we are not too concerned about a small deviation that is
invisible to the human eye.

Extract QImage::Format parsing into its own header

Use the array-of-strings suggested by David Faure so that only one list
has to be maintained instead of three.


Diffs (updated)
-----

  autotests/CMakeLists.txt 5c6508490344ca29097a3f13d01571658ad34786 
  autotests/readtest.cpp dec9686e38389b04296fdf176db9fb8c1f3a56a4 
  tests/format-enum.h PRE-CREATION 
  tests/imagedump.cpp 4b38c07d151d9bcb895f49a76e2bd03ddee41487 

Diff: https://git.reviewboard.kde.org/r/116567/diff/


Testing
-------

imagedump still works.  Most tests still pass; note that the non-alpha pic tests fail without https://git.reviewboard.kde.org/r/116568/diff/ as the wrong format (ARGB32 instead of RGB32) is constructed.

This should make the xcf tests pass again on Jenkins.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140303/98c1b492/attachment-0001.html>