kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

[Aurélien Gâteau]

On Sat, Mar 1, 2014, at 6:37, David Faure wrote:
> On Saturday 01 March 2014 13:37:31 Kevin Krammer wrote:
> > On Saturday, 2014-03-01, 13:19:23, David Faure wrote:
> > > On Saturday 01 March 2014 12:12:37 KDE CI System wrote:
> > > > CMake Error at CMakeLists.txt:30 (find_package):
> > > >   Could not find a configuration file for package "KF5DocTools" that is
> > > >   compatible with requested version "4.97.0".
> > > >   
> > > >   The following configuration files were considered but not accepted:
> > > >     /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdoctools/i
> > > >     ns
> > > >     t/
> > > > 
> > > > lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake, version: 4.96.0
> > > 
> > > Interesting, so kjsembed lies when it says "tier2", because it depends on
> > > kdoctools which also says "tier2".
> > > 
> > > Kevin, was 3064544f814813e4f528e7902f567e5ec4a30ffd in kjsembed wrong?
> > 
> > If it does need another tier2 framework other then the old ki18n then yes.
> > I checked the diagrams I was pointed at during the IRC meeting and it only
> > had ki18n and kjs as dependencies.
> 
> I see. The diagrams are wrong/outdated :)
> 
> Aurélien: you added kdoctools to kjsembed in c5dc9c1d03.

Mmm, which repository are you referring to? I can't find such a revision
in the kjsembed repository.

> Can you regenerate the diagrams maybe? (so we also get the ki18n tier
> change 
> in there?)

Good news: diagrams should now automatically be generated on
api.kde.org! I was about to announce it.
KJSEmbed diagram is here:

http://api.kde.org/frameworks-api/frameworks5-apidocs/kjsembed/html/kjsembed-dependencies.html

I had a look at the CMake code in KJSEmbed: it does not link to any
target provided by KDocTools, so CMake Graphviz code does not list it as
a dependency. You can declare the dependency manually. I documented how
to do it here:

http://techbase.kde.org/Policies/KDE_Frameworks_Documentation_Policy#.24framework.yaml

I can do it if you prefer, but I am interested in finding out whether my
doc is understandable :)

If I am not mistaken, KJSEmbed depends on KDocTools because it uses
kdoctools_create_manpage. Would it be an option to generate the man page
without KDocTools. It's a bit sad to bump it from tier 2 to tier 3 just
because of this.

Aurélien