Review Request 116030: Extend tests to cover getConf... calls

Kevin Krammer krammer at kde.org
Sat Mar 1 16:24:59 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116030/
-----------------------------------------------------------

(Updated March 1, 2014, 4:24 p.m.)


Review request for KDE Frameworks and Chusslove Illich.


Changes
-------

Deploy a test config file instead of creating one.
Removed left over debug output


Repository: ki18n


Description
-------

Write a test config to a test location using QStandardPath's test feature.
Test getConf... calls in success and fallback mode.
Actually found a missing bool -> script bool conversion. fixed

Chusslove: how about using ktranscript.ini for the file to look up using QStandardPaths? Maybe a more obvious on other platforms?


Diffs (updated)
-----

  autotests/CMakeLists.txt 6e926ba 
  autotests/ktranscript-test.ini PRE-CREATION 
  autotests/ktranscripttest.h 7ea7818 
  autotests/ktranscripttest.cpp e3a27ff 
  autotests/test.js ad53b1b 
  autotests/testhelpers.h PRE-CREATION 
  autotests/testhelpers.cpp PRE-CREATION 
  src/ktranscript.cpp 44c8b63 

Diff: https://git.reviewboard.kde.org/r/116030/diff/


Testing
-------

All previously existing tests continue to run :)


Thanks,

Kevin Krammer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140301/f142436e/attachment.html>


More information about the Kde-frameworks-devel mailing list