Review Request 116124: Always compile static lib with -fPIC

David Faure faure at kde.org
Sat Mar 1 10:22:39 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116124/#review51413
-----------------------------------------------------------

Ship it!


Looks correct.

- David Faure


On Feb. 27, 2014, 3:21 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116124/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 3:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> Always compile static lib with -fPIC
> 
> See
> http://mail.kde.org/pipermail/kde-frameworks-devel/2014-February/012375.html
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 0329bd383415b4fa265c1edd7f0f7d384fd17395 
> 
> Diff: https://git.reviewboard.kde.org/r/116124/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140301/36a3e46c/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list