Review Request 116064: @deprecated docs for KUrl methods that duplicate QUrl methods

[David Faure]

> On Feb. 26, 2014, 9:12 a.m., David Gil Oliva wrote:
> > src/kdecore/kurl.h, line 386
> > <https://git.reviewboard.kde.org/r/116064/diff/1/?file=246155#file246155line386>
> >
> >     I would say:
> >     
> >     @deprecated since 5.0, use Foo instead.
> >     
> >
> 
> Alex Merry wrote:
>     I'm not sure how useful that is; everything in kde4support is deprecated since 5.0 by definition.

That is not true. Some things in there can be deprecated since 4.3, 4.4, 4.7 ....

Please use "deprecated since 5.0" so we do this everywhere, it's useful when looking at the api docs for a certain version while still targeting older versions (same reasoning as "@since x.y").


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116064/#review50906
-----------------------------------------------------------


On Feb. 25, 2014, 11:03 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116064/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 11:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> @deprecated docs for KUrl methods that duplicate QUrl methods
> 
> Some KUrl methods just forward to their QUrl counterparts (or do
> .isEmpty() on a QUrl method result); replace the apidox for these with a
> note saying what QUrl method should be used instead.
> 
> 
> Diffs
> -----
> 
>   src/kdecore/kurl.h 4ac893382c76def83f8e6e12698931df243085f9 
> 
> Diff: https://git.reviewboard.kde.org/r/116064/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140301/0b8a5198/attachment.html>