Review Request 119005: Make desktoptojson include all values, not just the translated ones

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119005/
-----------------------------------------------------------

(Updated June 28, 2014, 11:47 p.m.)


Review request for KDE Frameworks.


Changes
-------

use QJsonArray::fromStringList and add missing newline in error message


Repository: kservice


Description
-------

It now uses QSettings to read the desktop file instead of kconfig which
means that this tool could move to kcoreaddons.


Diffs (updated)
-----

  src/desktoptojson/CMakeLists.txt 134dabe62ca051eea26631aedc72b108e1b60444 
  src/desktoptojson/kconfigtojson.cpp 5c0d751f05503e471ed9c49efc51bfdd22774be9 

Diff: https://git.reviewboard.kde.org/r/119005/diff/


Testing
-------

now includes all fields (Comment + Comment[de] + Comment[...], etc)

I guess desktoptojson could be move to kcoreaddons for 5.1 and have kservice_desktop_to_json forward to a new kcoreaddons_desktop_to_json for cmake source compatibility


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140628/cc5279b7/attachment.html>